flowbox: Sink the floating reference of model-based children

We don't want to leak references if the widget created to represent the
item in the model does not have a floating reference — which is usually
what happens in bindings, as they automatically sink references when
creating new instances.

See commit 6e03e7e8 for the similar change in GtkListBox.

diff --git a/gtk/gtkflowbox.c b/gtk/gtkflowbox.c
index 40d60a240ade4164cf86f81188294e490e3978d6..e84b3597a9179d06bc572321b85accde8a86e06b 100644 (file)
--- a/gtk/gtkflowbox.c
+++ b/gtk/gtkflowbox.c
@@ -4036,9 +4036,22 @@ gtk_flow_box_bound_model_changed (GListModel *list,
 
       item = g_list_model_get_item (list, position + i);
       widget = priv->create_widget_func (item, priv->create_widget_func_data);
+
+      /* We need to sink the floating reference here, so that we can accept
+       * both instances created with a floating reference (e.g. C functions
+       * that just return the result of g_object_new()) and without (e.g.
+       * from language bindings which will automatically sink the floating
+       * reference).
+       *
+       * See the similar code in gtklistbox.c:gtk_list_box_bound_model_changed.
+       */
+      if (g_object_is_floating (widget))
+        g_object_ref_sink (widget);
+
       gtk_widget_show (widget);
       gtk_flow_box_insert (box, widget, position + i);
 
+      g_object_unref (widget);
       g_object_unref (item);
     }
 }